[PATCH] D127965: [VPlan] Move recipe implementations to separate file (NFC).

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:38
 #include "llvm/Support/Debug.h"
-#include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/GenericDomTreeConstruction.h"
----------------
Ayal wrote:
> Hmm, this is not needed at all?
I don't think so, likely the code using it has been moved somewhere else or has been removed alltogether.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:1139
 
-#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
 Twine VPlanPrinter::getUID(const VPBlockBase *Block) {
----------------
Ayal wrote:
> Ah, this #if should stay?
Yes, re-added!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:1340
-
-#endif
-
----------------
Ayal wrote:
> Keep this #endif to end the above #if.
Done, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:1
+//===- VPlan.cpp - Vectorizer Plan ----------------------------------------===//
+//
----------------
Ayal wrote:
> File name above and \file description below need to be updated.
thanks, should be fixed in the latest version!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:261
+  }
+
+  case VPInstruction::CanonicalIVIncrement:
----------------
Ayal wrote:
> nit: while we're here, can remove empty line for consistency.
removed, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:474
+}
+
+#endif
----------------
Ayal wrote:
> nit: remove empty line for consistency.
Done, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127965/new/

https://reviews.llvm.org/D127965