[PATCH] D127965: [VPlan] Move recipe implementations to separate file (NFC).

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 440193.
fhahn marked 6 inline comments as done.
fhahn added a comment.

Adress latest comments, thanks!

> Nice move! Would it be reasonable to also have a matching VPlanRecipes.h, excluding VPRecipeBase?

I think this would require a bit more surgery, as VPlan.h contains multiple function definitions that require the full definition of different recipes types. This could be resovled by moving them to VPlan.cpp, but I think that would be best done separately. Also, I think in most file we would have to include both headers in any case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127965/new/

https://reviews.llvm.org/D127965

Files:
  llvm/lib/Transforms/Vectorize/CMakeLists.txt
  llvm/lib/Transforms/Vectorize/VPlan.cpp
  llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127965.440193.patch
Type: text/x-patch
Size: 59786 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220627/e1c80f8f/attachment.bin>