[PATCH] D128094: [WebAssembly][Object] Remove requirement that objects must have code sections

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 18:07:24 PDT 2022


aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

> (Also we can't just always require the presence of e.g. the
> function or global sections, because a binary may just have any functions.
> There's only an problem if the name or linking section tries to name a
> nonexistent function).

Code LGTM, but not sure what this sentence means.. Can you provide a little more context?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128094/new/

https://reviews.llvm.org/D128094



More information about the llvm-commits mailing list