[PATCH] D128094: [WebAssembly][Object] Remove requirement that objects must have code sections

Fri Jun 17 13:52:20 PDT 2022

dschuff added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/wasm/no-codesec.test:26
+     - Index:          0
+       Name:           foo
----------------
dschuff wrote:
> sbc100 wrote:
> > This is no longer a valid wasm file though right?  Since it refers to a function that doesn't have a body.   I guess that is maybe ok as long as we produce valid wasm files by default?
> Correct; I think a function without a body would not validate. The use case for this is to have a wasm file with just debug info in it (e.g. to take a debug-info-containing wasm file and ship a stripped version, and archive the debug info separately).
and I think that's ok for low-level tools like objcopy and objdump.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128094/new/

https://reviews.llvm.org/D128094