[PATCH] D127915: [windows][support] Improve backtrace emitted in crash report without llvm-symbolizer

Fri Jun 17 15:09:05 PDT 2022

dblaikie added a comment.

In D127915#3592409 <https://reviews.llvm.org/D127915#3592409>, @bd1976llvm wrote:

> In D127915#3590333 <https://reviews.llvm.org/D127915#3590333>, @dblaikie wrote:
>
>> how's this compare to the linux behavior? be nice to have a similar format
>
> There are differences. This doesn't really bother me as a crash dump is platform specific but if this is important I can try to make the output consistent (or maybe that should be another change)?

oh, wasn't so much about it being exactly the same formatting (though that seems nice to have) - but whether it contained the same information (or is there a real difference between the platforms that motivates the differences?) - like I don't recall any of this parameter dumping in the linux crash dump.

(& maybe if the OS-specific part was lower level (surfacing the module base addresses and offsets) leaving the rendering to a higher level portable piece of code, that'd address the inconsistencies and reduce code duplication?)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127915/new/

https://reviews.llvm.org/D127915