[PATCH] D127915: [windows][support] Improve backtrace emitted in crash report without llvm-symbolizer

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

+1 for the exception code. I think it may appear as the process return code and some systems will log that, but logging it ourselves, too, is for the best.

I think we could probably go further here. The unsymbolized output when we use llvm-symbolizer and it can't find PDB files is practically the same as the new output with your change. It would be nice to be able to fetch symbols and then re-pipe the crash report text through llvm-symbolizer and get a symbolized stack trace. That can be future work, this is a nice improvement as is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127915/new/

https://reviews.llvm.org/D127915