[PATCH] D127915: [windows][support] Improve backtrace emitted in crash report without llvm-symbolizer

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D127915#3592534 <https://reviews.llvm.org/D127915#3592534>, @rnk wrote:

> lgtm
>
> +1 for the exception code. I think it may appear as the process return code and some systems will log that, but logging it ourselves, too, is for the best.
>
> I think we could probably go further here. The unsymbolized output when we use llvm-symbolizer and it can't find PDB files is practically the same as the new output with your change. It would be nice to be able to fetch symbols and then re-pipe the crash report text through llvm-symbolizer and get a symbolized stack trace. That can be future work, this is a nice improvement as is.

That sounds like this: https://reviews.llvm.org/D126980 perhaps? (we could change the crash dump output to include the markup required for the filtering, specifically when we can't already symbolize at crash-time)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127915/new/

https://reviews.llvm.org/D127915