[PATCH] D127808: [memprof] Update the test comments to include -Wl,-no-pie
Snehasish Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 14 17:01:49 PDT 2022
snehasish updated this revision to Diff 436978.
snehasish added a comment.
Update binary names to be consistent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127808/new/
https://reviews.llvm.org/D127808
Files:
llvm/test/tools/llvm-profdata/memprof-basic.test
llvm/test/tools/llvm-profdata/memprof-inline.test
llvm/test/tools/llvm-profdata/memprof-merge.test
llvm/test/tools/llvm-profdata/memprof-multi.test
Index: llvm/test/tools/llvm-profdata/memprof-multi.test
===================================================================
--- llvm/test/tools/llvm-profdata/memprof-multi.test
+++ llvm/test/tools/llvm-profdata/memprof-multi.test
@@ -28,9 +28,10 @@
```
clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
-fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
- -fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o multi.memprofexe
+ -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
+ source.c -o multi.memprofexe
-env MEMPROF_OPTIONS=log_path=stdout ./rawprofile.out > multi.memprofraw
+env MEMPROF_OPTIONS=log_path=stdout ./multi.memprofexe > multi.memprofraw
```
RUN: llvm-profdata show --memory %p/Inputs/multi.memprofraw --profiled-binary %p/Inputs/multi.memprofexe -o - | FileCheck %s
Index: llvm/test/tools/llvm-profdata/memprof-merge.test
===================================================================
--- llvm/test/tools/llvm-profdata/memprof-merge.test
+++ llvm/test/tools/llvm-profdata/memprof-merge.test
@@ -28,9 +28,10 @@
# Collect memprof profile.
clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
-fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
- -fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o basic.memprofexe
+ -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
+ source.c -o basic.memprofexe
-env MEMPROF_OPTIONS=log_path=stdout ./rawprofile.out > basic.memprofraw
+env MEMPROF_OPTIONS=log_path=stdout ./basic.memprofexe > basic.memprofraw
```
RUN: llvm-profdata merge %p/Inputs/basic.profraw %p/Inputs/basic.memprofraw --profiled-binary %p/Inputs/basic.memprofexe -o %t.prof
Index: llvm/test/tools/llvm-profdata/memprof-inline.test
===================================================================
--- llvm/test/tools/llvm-profdata/memprof-inline.test
+++ llvm/test/tools/llvm-profdata/memprof-inline.test
@@ -30,9 +30,10 @@
```
bin/clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
-fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
- -fno-optimize-sibling-calls -m64 -Wl,-build-id inline.c -o memprof-inline.exe
+ -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
+ inline.c -o inline.memprofexe
-env MEMPROF_OPTIONS=log_path=stdout ./memprof-inline.exe > inline.memprofraw
+env MEMPROF_OPTIONS=log_path=stdout ./inline.memprofexe > inline.memprofraw
```
RUN: llvm-profdata show --memory %p/Inputs/inline.memprofraw --profiled-binary %p/Inputs/inline.memprofexe | FileCheck %s
Index: llvm/test/tools/llvm-profdata/memprof-basic.test
===================================================================
--- llvm/test/tools/llvm-profdata/memprof-basic.test
+++ llvm/test/tools/llvm-profdata/memprof-basic.test
@@ -26,9 +26,10 @@
```
clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
-fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
- -fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o basic.memprofexe
+ -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
+ source.c -o basic.memprofexe
-env MEMPROF_OPTIONS=log_path=stdout ./rawprofile.out > basic.memprofraw
+env MEMPROF_OPTIONS=log_path=stdout ./basic.memprofexe > basic.memprofraw
```
RUN: llvm-profdata show --memory %p/Inputs/basic.memprofraw --profiled-binary %p/Inputs/basic.memprofexe -o - | FileCheck %s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127808.436978.patch
Type: text/x-patch
Size: 3568 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220615/695f9c54/attachment.bin>
More information about the llvm-commits
mailing list