[PATCH] D127808: [memprof] Update the test comments to include -Wl,-no-pie

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 16:36:01 PDT 2022


tejohnson added inline comments.


================
Comment at: llvm/test/tools/llvm-profdata/memprof-basic.test:29
       -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-      -fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o basic.memprofexe
+      -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
+      source.c -o basic.memprofexe
----------------
Do we also need -fno-pie here and elsewhere?


================
Comment at: llvm/test/tools/llvm-profdata/memprof-basic.test:32
 
 env MEMPROF_OPTIONS=log_path=stdout ./rawprofile.out > basic.memprofraw
 ```
----------------
BTW I noticed that the binary name here and in a couple other files is wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127808/new/

https://reviews.llvm.org/D127808



More information about the llvm-commits mailing list