[PATCH] D127808: [memprof] Update the test comments to include -Wl,-no-pie

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish marked an inline comment as done.
snehasish added a comment.

PTAL, thanks!



================
Comment at: llvm/test/tools/llvm-profdata/memprof-basic.test:29
       -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-      -fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o basic.memprofexe
+      -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
+      source.c -o basic.memprofexe
----------------
tejohnson wrote:
> Do we also need -fno-pie here and elsewhere?
No, I checked for this test case (and the others in this patch) -Wl,-no-pie is sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127808/new/

https://reviews.llvm.org/D127808