[PATCH] D125680: Correctly legalise stackmap operands

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

General direction looks reasonable.  I do want to warn you that to my knowledge, no one is using stackmap or patchpoint.  I believe they've been effectively dead code for the last couple years.  statepoint is used, and should provide a superset of the stackmap/patchpoint functionality.

Code structure wise, would it be possibly to split this patch?  (Warning: I am no selectiondag expert!)  Could we add the SDNode in an NFC patch which does not legalize, and then handle legalization in a separate patch?  If we can, it might make some of the review (mapping argument orders, etc) more straight forward.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125680/new/

https://reviews.llvm.org/D125680