[PATCH] D125680: Correctly legalise stackmap operands

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 17 07:30:12 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:2286
+      // Otherwise it's a register.
+      // XXX ^^ is this true?
+      O = *It; // XXX Also does this guarantee register selection?
----------------
vext01 wrote:
> arsenm wrote:
> > FrameIndex will also be materialized into a register, unlike TargetFrameIndex
> And is that correct?
Well the current code is emitting TargetFrameIndexes into the argument list, so I assume this should also just go direct to TargetFrameIndex from the start


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125680/new/

https://reviews.llvm.org/D125680



More information about the llvm-commits mailing list