[PATCH] D125680: Correctly legalise stackmap operands

[Edd Barrett via Phabricator via llvm-commits]

vext01 added inline comments.


================
Comment at: llvm/test/CodeGen/X86/selectiondag-stackmap-legalize.ll:2
+; RUN: llc -debug-only=legalize-types -print-after=finalize-isel %s -O1 -mtriple=x86_64-unknown-unknown -o /dev/null 2>&1 | FileCheck %s
+
+
----------------
vext01 wrote:
> arsenm wrote:
> > vext01 wrote:
> > > arsenm wrote:
> > > > vext01 wrote:
> > > > > arsenm wrote:
> > > > > > If you're checking debug output you need REQUIRES: asserts. However, I don't think checking the legalizer output is the most helpful thing here. Better to check the final output
> > > > > At what level should I check?
> > > > > 
> > > > > I wanted to check at the MIR level, but it doesn't show the types there.
> > > > The types are meaningless after selection, so that makes sense. I would default to codegen to the end. MIR is less stable and what you care about is that the types were legalized to and selected to something, not the types themselves
> > > >  I would default to codegen to the end
> > > 
> > > Do you mean to match asm code for the target architecture? Isn't that also going to be fragile?
> > Yes. No, this is a target specific test anyway. 
> Stackmap doesn't emit any code that we could match, but we could match the raw bytes of the `.llvmbc` section, just it's very fiddly.
> 
> If that's the only way, so be it.
sorry, not `.llvmbc`, I meant the stackmap section.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125680/new/

https://reviews.llvm.org/D125680