[PATCH] D125643: [ARM SEH 1] [llvm-readobj] Fix printing of Windows ARM unwind opcodes, add tests

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp:77
   switch (RT) {
   case ARM::WinEH::ReturnType::RT_POP:
     OS << "pop {pc}";
----------------
efriedma wrote:
> Is RT_POP simply unused?
Oh, nevermind, there's casts to the enum.


================
Comment at: llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp:204
+void Decoder::printRegisters(
+    const std::pair<uint16_t, uint32_t> &RegisterMask) {
   const uint16_t GPRMask = std::get<0>(RegisterMask);
----------------
efriedma wrote:
> While you're here, can you split printRegisters() into separate functions PrintGPRRegisters/PrintVFPRegisters?  You've extracted out most of the shared logic anyway.
Just saw this is in the followup patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125643/new/

https://reviews.llvm.org/D125643