[PATCH] D125643: [ARM SEH 1] [llvm-readobj] Fix printing of Windows ARM unwind opcodes, add tests

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ARMWinEHPrinter.cpp:979
+      // prologue, we print this even if EpilogueCount() (aka EpilogueOffset)
+      // is zero.
       ListScope ES(SW, "Epilogue");
----------------
efriedma wrote:
> The `isAArch64 || !XData.F()` checks feel weird; even if the "F" bit is set, the prologue still has an effect.  (The AArch64 equivalent is a prologue where the first opcode is end_c.)  I think I'd prefer to just unconditionally print the prologue.
Yep, I agree. I clearly hadn't understood the fragments properly when I implemented this part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125643/new/

https://reviews.llvm.org/D125643