[PATCH] D125377: [AArch64] Order STP Q's by ascending address
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 12 01:08:34 PDT 2022
dmgreen added reviewers: fhahn, t.p.northover.
dmgreen added a comment.
In order sounds sensible to me. We may need a subtarget feature for this, it depends on what the Apple folks think, but we can always add one later if needed.
================
Comment at: llvm/lib/Target/AArch64/AArch64MachineScheduler.cpp:18
+
+ if (Cand.isValid()) {
+ MachineInstr *Instr0 = TryCand.SU->getInstr();
----------------
Can you add a comment explaining what this is doing and why.
================
Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:488
return nullptr;
}
----------------
Should this either return DAG, or create DAG inside the if.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125377/new/
https://reviews.llvm.org/D125377
More information about the llvm-commits
mailing list