[PATCH] D125377: [AArch64] Order STP Q's by ascending address

Andre Vieira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 01:37:26 PDT 2022


avieira added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64MachineScheduler.cpp:18
+
+  if (Cand.isValid()) {
+    MachineInstr *Instr0 = TryCand.SU->getInstr();
----------------
dmgreen wrote:
> Can you add a comment explaining what this is doing and why.
That sounds like a good idea yeah ;) 


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:488
 
     return nullptr;
   }
----------------
dmgreen wrote:
> Should this either return DAG, or create DAG inside the if.
Ah yeah good catch! Forgot to change that when I moved the DSG creation out of the Fusion check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125377/new/

https://reviews.llvm.org/D125377



More information about the llvm-commits mailing list