[PATCH] D124884: [AMDGPU] Add intrinsic llvm.amdgcn.raw.buffer.load.lds

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 12:42:04 PDT 2022


rampitec added a comment.
Herald added a subscriber: jsilvanus.

In D124884#3490643 <https://reviews.llvm.org/D124884#3490643>, @arsenm wrote:

> In D124884#3489967 <https://reviews.llvm.org/D124884#3489967>, @rampitec wrote:
>
>> To confirm: is that OK to add yet another imm to the end of operands of the intrinsic to select a byte size? And then remove the overload. If yes I will do it tomorrow.
>
> There's the elementtype attribute for this case which some arm intrinsics seem to be using. Not sure how you're supposed to define an intrinsic to use it though

This will need a clang builtin to produce the attribute. I am not sure we really want to expose it as a clang builtin.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124884/new/

https://reviews.llvm.org/D124884



More information about the llvm-commits mailing list