[PATCH] D124884: [AMDGPU] Add intrinsic llvm.amdgcn.raw.buffer.load.lds

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 04:26:21 PDT 2022


arsenm added a comment.

In D124884#3490731 <https://reviews.llvm.org/D124884#3490731>, @nhaehnle wrote:

> What's wrong with the idea of an `i32 imm %size` argument? That seems to me more in line with the philosophy of caring less about types.

I'd prefer to keep any intrinsics that look like a load or store to look more like the regular load or store instructions. All of these arbitrary immediate parameters are uglier (e.g. the memory ordering arguments that don't actually work on some of the atomics)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124884/new/

https://reviews.llvm.org/D124884



More information about the llvm-commits mailing list