[PATCH] D124884: [AMDGPU] Add intrinsic llvm.amdgcn.raw.buffer.load.lds

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D124884#3490745 <https://reviews.llvm.org/D124884#3490745>, @arsenm wrote:

> In D124884#3490731 <https://reviews.llvm.org/D124884#3490731>, @nhaehnle wrote:
>
>> What's wrong with the idea of an `i32 imm %size` argument? That seems to me more in line with the philosophy of caring less about types.
>
> I'd prefer to keep any intrinsics that look like a load or store to look more like the regular load or store instructions. All of these arbitrary immediate parameters are uglier (e.g. the memory ordering arguments that don't actually work on some of the atomics)

It is more or less similar to memcpy, and memcpy uses size argument.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124884/new/

https://reviews.llvm.org/D124884