[PATCH] D124884: [AMDGPU] Add intrinsic llvm.amdgcn.raw.buffer.load.lds

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

In D124884#3490649 <https://reviews.llvm.org/D124884#3490649>, @arsenm wrote:

> In D124884#3490643 <https://reviews.llvm.org/D124884#3490643>, @arsenm wrote:
>
>> In D124884#3489967 <https://reviews.llvm.org/D124884#3489967>, @rampitec wrote:
>>
>>> To confirm: is that OK to add yet another imm to the end of operands of the intrinsic to select a byte size? And then remove the overload. If yes I will do it tomorrow.
>>
>> There's the elementtype attribute for this case which some arm intrinsics seem to be using. Not sure how you're supposed to define an intrinsic to use it though
>
> Apparently this isn't well developed but works. The verifier is hardcoding these intrinsics (it's also looking at the call site instead of the intrinsic declaration attributes)

What's wrong with the idea of an `i32 imm %size` argument? That seems to me more in line with the philosophy of caring less about types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124884/new/

https://reviews.llvm.org/D124884