[PATCH] D120960: [M68k][Disassembler] Adopt the new variable length decoder

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

In D120960#3486430 <https://reviews.llvm.org/D120960#3486430>, @0x59616e wrote:

> In D120960#3484760 <https://reviews.llvm.org/D120960#3484760>, @myhsu wrote:
>
>> just want to double check: all of the previously-XFAIL tests are now passing, right?
>
> Yes. I don't see any 'unexpectedly passed' test.

This is a good news and proofs that the new variable-length decoder infrastructure works at scale :-)
(at least at a certain scale given that we still more coverage on our disassembler tests)



================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:23
 #include "llvm/MC/MCDisassembler/MCDisassembler.h"
+#include "llvm/MC/MCFixedLenDisassembler.h"
 #include "llvm/MC/MCInst.h"
----------------
0x59616e wrote:
> myhsu wrote:
> > I'm wonder if we want to rename this file as well?
> I think `MCDecoderOps.h` is more suitable.
> 
> Should we create another revision for it ?
> I think MCDecoderOps.h is more suitable.

Agree.

> Should we create another revision for it ?

Sounds good to me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120960/new/

https://reviews.llvm.org/D120960