[PATCH] D120960: [M68k][Disassembler] Adopt the new variable length decoder

Sheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 12:14:28 PDT 2022


0x59616e added a comment.

In D120960#3484760 <https://reviews.llvm.org/D120960#3484760>, @myhsu wrote:

> just want to double check: all of the previously-XFAIL tests are now passing, right?

Yap.



================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:23
 #include "llvm/MC/MCDisassembler/MCDisassembler.h"
+#include "llvm/MC/MCFixedLenDisassembler.h"
 #include "llvm/MC/MCInst.h"
----------------
myhsu wrote:
> I'm wonder if we want to rename this file as well?
I think `MCDecoderOps.h` is more suitable.

Should we create another revision for it ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120960/new/

https://reviews.llvm.org/D120960



More information about the llvm-commits mailing list