[PATCH] D120960: [M68k][Disassembler] Adopt the new variable length decoder

[Sheng via Phabricator via llvm-commits]

0x59616e added a comment.

In D120960#3488691 <https://reviews.llvm.org/D120960#3488691>, @myhsu wrote:

> In D120960#3486430 <https://reviews.llvm.org/D120960#3486430>, @0x59616e wrote:
>
>> In D120960#3484760 <https://reviews.llvm.org/D120960#3484760>, @myhsu wrote:
>>
>>> just want to double check: all of the previously-XFAIL tests are now passing, right?
>>
>> Yes. I don't see any 'unexpectedly passed' test.
>
> This is a good news and proofs that the new variable-length decoder infrastructure works at scale :-)
> (at least at a certain scale given that we still more coverage on our disassembler tests)

I'll open a bug tracker for this after landing this revision.



================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:23
 #include "llvm/MC/MCDisassembler/MCDisassembler.h"
+#include "llvm/MC/MCFixedLenDisassembler.h"
 #include "llvm/MC/MCInst.h"
----------------
myhsu wrote:
> 0x59616e wrote:
> > myhsu wrote:
> > > I'm wonder if we want to rename this file as well?
> > I think `MCDecoderOps.h` is more suitable.
> > 
> > Should we create another revision for it ?
> > I think MCDecoderOps.h is more suitable.
> 
> Agree.
> 
> > Should we create another revision for it ?
> 
> Sounds good to me
I'll do it later. Thanks ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120960/new/

https://reviews.llvm.org/D120960