[PATCH] D123264: [RISCV] Pre-RA expand pseudos pass

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

In D123264#3459427 <https://reviews.llvm.org/D123264#3459427>, @jrtc27 wrote:

> This doesn't make sense to me?

Right, that was silly, I was confused. I'll remove it from the summary.



================
Comment at: llvm/lib/Target/RISCV/RISCVExpandPseudoInsts.cpp:439
+  Symbol.setTargetFlags(FlagsHi);
+  MCSymbol *AUIPCSymbol = MF->getContext().createNamedTempSymbol("PCRelHi");
+
----------------
jrtc27 wrote:
> As a quick non-technical comment, if we're going to give names to these symbols, can we please use .Lpcrel_hiN to match what you get from expanding the pseudos in RISCVAsmParser rather than a different spelling of the same thing?
Yes, I'll update it in the next revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123264/new/

https://reviews.llvm.org/D123264