[PATCH] D123970: [RISCV] Add isCommutable to ADD/ADDW/MUL/AND/OR/XOR.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D123970#3457836 <https://reviews.llvm.org/D123970#3457836>, @jrtc27 wrote:

> Might be clearer as `let isCommutable = 1/true in` on each def? There aren't that many of them, so that keeps it self-documenting and avoids long argument lists.

I've added an inline comment. Not sure if that's more acceptable or not. This way it keeps every instruction having the same number of lines so it's more regular than adding in extra `let` lines. I could be persuaded to add the `let isCommutable` if others feel strongly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123970/new/

https://reviews.llvm.org/D123970