[PATCH] D123951: [LLVM] Add exported visibility-style to IR for XCOFF

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/IR/AsmWriter.cpp:3155
+  case GlobalValue::ExportedVisibility:
+    return "exported";
   }
----------------
if I understand correct. this is for IR generate, if add it now, I do not think we can have a test case for it now ? It maybe better to add when implement the frontend.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1905
+      break;
+    // TODO: "internal" Visibility needs to go here.
     case GlobalValue::DefaultVisibility:
----------------
maybe better  to change to 
// TODO: "internal" Visibility needs to go here.
 case GlobalValue::ExportedVisibility:
      VisibilityAttr = MAI->getExportedVisibilityAttr();
      break;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123951/new/

https://reviews.llvm.org/D123951