[PATCH] D123951: [LLVM] Add exported visibility-style to IR for XCOFF

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 13:57:54 PDT 2022


DiggerLin added a comment.

we need to change the following functions to deal with MCSA_Exported

1. MCWasmStreamer::emitSymbolAttribute(MCSymbol *S, MCSymbolAttr Attribute) too .
2. MCXCOFFStreamer::emitSymbolAttribute(MCSymbol *Sym, MCSymbolAttr Attribute)



================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:767
+  case MCSA_Exported:
+    // Non-AIX assemblers currently do not support exported visibility.
+    return false;
----------------
change to 
 case MCSA_Cold:
    // Assemblers currently do not support a .cold directive.
case MCSA_Exported:
    // Non-AIX assemblers currently do not support exported visibility.
   return false;

?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123951/new/

https://reviews.llvm.org/D123951



More information about the llvm-commits mailing list