[PATCH] D123951: [LLVM] Add exported visibility-style to IR for XCOFF

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 15:51:10 PDT 2022


daltenty marked 2 inline comments as done.
daltenty added inline comments.


================
Comment at: llvm/lib/IR/AsmWriter.cpp:3155
+  case GlobalValue::ExportedVisibility:
+    return "exported";
   }
----------------
DiggerLin wrote:
> if I understand correct. this is for IR generate, if add it now, I do not think we can have a test case for it now ? It maybe better to add when implement the frontend.
Thanks for catching that, I've added a seperate unit test since none seems to exist currently.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123951/new/

https://reviews.llvm.org/D123951



More information about the llvm-commits mailing list