[PATCH] D123863: MIR: Serialize a few bool function fields

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 10:42:06 PDT 2022


arsenm added a comment.

In D123863#3454366 <https://reviews.llvm.org/D123863#3454366>, @MatzeB wrote:

> At a first glance:
>
> - `HasEHFunclets` and `HasEHScopes` both seem to be true iff there's an EHPad basic block which should be testable with `MBB.isEHPad`? Admittedly I don't understand why those two variables, it seems we only ever set them both in ` FunctionLoweringInfo::set`...

But it's set conditionally based on isa<LandingPadInst>(BB.getFirstNonPHI()), so EHPad doesn't necessarily imply them (but I have no understanding of how this exception stuff is supposed to work)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123863/new/

https://reviews.llvm.org/D123863



More information about the llvm-commits mailing list