[PATCH] D123863: MIR: Serialize a few bool function fields

Fri Apr 15 11:00:46 PDT 2022

MatzeB added a comment.

In D123863#3454376 <https://reviews.llvm.org/D123863#3454376>, @arsenm wrote:

> In D123863#3454366 <https://reviews.llvm.org/D123863#3454366>, @MatzeB wrote:
>
>> At a first glance:
>>
>> - `HasEHFunclets` and `HasEHScopes` both seem to be true iff there's an EHPad basic block which should be testable with `MBB.isEHPad`? Admittedly I don't understand why those two variables, it seems we only ever set them both in ` FunctionLoweringInfo::set`...
>
> But it's set conditionally based on isa<LandingPadInst>(BB.getFirstNonPHI()), so EHPad doesn't necessarily imply them (but I have no understanding of how this exception stuff is supposed to work)

I don't really have experience with EH either. So let's go ahead with the patch as-is then.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123863/new/

https://reviews.llvm.org/D123863