[PATCH] D123863: MIR: Serialize a few bool function fields

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 10:31:55 PDT 2022


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

At a first glance:

- `HasEHFunclets` and `HasEHScopes` both seem to be true iff there's an EHPad basic block which should be testable with `MBB.isEHPad`? Admittedly I don't understand why those two variables, it seems we only ever set them both in ` FunctionLoweringInfo::set`...
- I guess `CallsUnwind`, `CallsEHReturn`, `HasEHCatchret` has no easy/obvious way to compute since catchret patterns vary by target once things are lowered.

So yeah I think computing Funclets/Scopes is worth a try unless I am missing something.

Either way this change LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123863/new/

https://reviews.llvm.org/D123863



More information about the llvm-commits mailing list