[PATCH] D123863: MIR: Serialize a few bool function fields

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 10:20:38 PDT 2022


arsenm added a comment.

In D123863#3454299 <https://reviews.llvm.org/D123863#3454299>, @MatzeB wrote:

> Do you know whether we could compute their values instead? If the data can be derived by analyzing the function then we can add it to `MIRParserImpl::computeFunctionProperties` to compute them instead of explicitly serializing them.

CallsUnwindInit tracks a call to an IR intrinsic which is immediately discarded, so no.

For HasEHScopes, HasEHFunclets, and HasOpaqueSPAdjustment, I don't think so. It's set directly from the IR (and I think it's better to avoid as many backlinks there as possible).

For HasEHCatchret, it would require some kind of target knowledge to know what they selected ISD::CATCHRET to.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123863/new/

https://reviews.llvm.org/D123863



More information about the llvm-commits mailing list