[PATCH] D122918: [RISCV][CodeGen] Support float-arith in Zfinx

[Hugh Perkins via Phabricator via llvm-commits]

hughperkins added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoF.td:515
 /// Float arithmetic operations
+defm : PatFprFprDynFrm_m<any_fadd, FADD_S, FINX>;
+defm : PatFprFprDynFrm_m<any_fsub, FSUB_S, FINX>;
----------------
I think it's confusing that `FINX` in this context means `F` and `F_INX`. I feel it might be good to make more explicit that `FINX` includes `F`. How to do that is an open question. I'd suggest `FFINX`, but `FFINX` is already taken to mean `FF` with `FF_INX`. Maybe we need an explicit acronym to mean 'F and F_INX', like e.g. 'ALLF'. Or perhaps use a verbose form like 'F_AND_FINX'? (If it was my own decision I'd go for the explicit `F_AND_FINX`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122918/new/

https://reviews.llvm.org/D122918