[PATCH] D123390: [demangler][NFC] OperatorInfo table unit test

Iain Sandoe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 00:54:02 PDT 2022


iains added a comment.

In D123390#3444794 <https://reviews.llvm.org/D123390#3444794>, @llunak wrote:

> The change looks good to me too, if that counts as anything from an outsider. But as an outsider I think you LLVM folks tend to overdo the perfectionism while reviewing. There's rather obviously nothing visibly wrong with the change, the chance it'll break something is extremely low, you apparently know this code, and you pushing this should be fine even according to the policy (the "likely-community-consensus" part)

+1 from me on all counts (as another person not familiar with the details of current libc++).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123390/new/

https://reviews.llvm.org/D123390



More information about the llvm-commits mailing list