[PATCH] D123390: [demangler][NFC] OperatorInfo table unit test

[Luboš Luňák via Phabricator via llvm-commits]

llunak added a comment.

The change looks good to me too, if that counts as anything from an outsider. But as an outsider I think you LLVM folks tend to overdo the perfectionism while reviewing. There's rather obviously nothing visibly wrong with the change, the chance it'll break something is extremely low, you apparently know this code, and you pushing this should be fine even according to the policy (the "likely-community-consensus" part) rather than blocking on somebody who apparently has a long enough review queue and could be instead reviewing changes that actually need it (*cough* D122974 <https://reviews.llvm.org/D122974> *cough*).

In D123390#3444623 <https://reviews.llvm.org/D123390#3444623>, @JDevlieghere wrote:

> To clarify: I think this change looks perfectly fine. The only reason I didn't want to accept this is because I'm not at all familiar with libc++. Case in point: I accepted D123158 <https://reviews.llvm.org/D123158> which turned out not to be the right thing :-)

Case in point: D123158 <https://reviews.llvm.org/D123158> would not have actually broken anything, so it's not a wrong thing either :).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123390/new/

https://reviews.llvm.org/D123390