[PATCH] D123390: [demangler][NFC] OperatorInfo table unit test

Nathan Sidwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 05:30:21 PDT 2022


urnathan added a comment.

In D123390#3444623 <https://reviews.llvm.org/D123390#3444623>, @JDevlieghere wrote:

> To clarify: I think this change looks perfectly fine. The only reason I didn't want to accept this is because I'm not at all familiar with libc++. Case in point: I accepted D123158 <https://reviews.llvm.org/D123158> which turned out not to be the right thing :-)

I understand and agree with your reasoning, I intended no blame and am sorry if it came across that way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123390/new/

https://reviews.llvm.org/D123390



More information about the llvm-commits mailing list