[PATCH] D122226: [llvm-pdbutil] Move InputFile/FormatUtil/LinePrinter to the PDB library.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added a comment.

In D122226#3417917 <https://reviews.llvm.org/D122226#3417917>, @zequanwu wrote:

> This causes `llvm-pdbutil` crashes when modi is neither 0 nor 1, e.g. `llvm-pdbutil dump --symbols -modi=2 a.pdb`

@zequanwu, these are my findings

Before this patch:

  llvm-pdbutil dump --symbols -modi=2 a.pdb --> OK
  llvm-pdbutil dump --symbols -modi=2 -modi=1 a.pdb --> Assertion.
  llvm-pdbutil dump --symbols -modi=1 -modi=2 a.pdb --> Assertion.
  Assertion failed: opts::dump::DumpModi.getNumOccurrences() == 1, file X:\llvm-root\llvm-project\llvm\tools\llvm-pdbutil\DumpOutputStyle.cpp, line 456

It means that the `-modi` argument can't be specified more than once.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122226/new/

https://reviews.llvm.org/D122226