[PATCH] D122226: [llvm-pdbutil] Move InputFile/FormatUtil/LinePrinter to the PDB library.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added a comment.

In D122226#3417917 <https://reviews.llvm.org/D122226#3417917>, @zequanwu wrote:

> This causes `llvm-pdbutil` crashes when modi is neither 0 nor 1, e.g. `llvm-pdbutil dump --symbols -modi=2 a.pdb`
>
>   llvm-pdbutil: ../../llvm/include/llvm/DebugInfo/PDB/Native/InputFile.h:185: llvm::Error llvm::pdb::iterateSymbolGroups(llvm::pdb::InputFile &, const Optional<llvm::pdb::PrintScope> &, CallbackT) [CallbackT = (lambda at ../../llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp:1472:7)]: Assertion `llvm::pdb::Filters.DumpModi == 1' failed.

I am sorry for my late reply.
When `InputFile.cpp[h]` were moved to the PDB library, no logic related with `modi` was changed.
I will have a look at it and raise a bugzilla for that issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122226/new/

https://reviews.llvm.org/D122226