[PATCH] D119148: [LoopUnroll] Always respect user unroll pragma

[Whitney Tsang via Phabricator via llvm-commits]

Whitney added a comment.

In D119148#3417337 <https://reviews.llvm.org/D119148#3417337>, @efriedma wrote:

> PragmaUnrollThreshold has other uses; are you intentionally leaving those alone?

Yes, it is still possible that `shouldPragmaUnroll` returns `None`, e.g., when `(UP.AllowRemainder || (TripMultiple % PInfo.PragmaCount == 0))` is `false`.
And we want to be more aggressive with unrolling limits when given an unrolling pragma.

  // If the loop has an unrolling pragma, we want to be more aggressive with                                                           
  // unrolling limits. Set thresholds to at least the PragmaUnrollThreshold                                                            
  // value which is larger than the default limits.

Thanks for your input.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119148/new/

https://reviews.llvm.org/D119148