[PATCH] D122082: Add DXIL Bitcode Writer and DXIL testing

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D122082#3433503 <https://reviews.llvm.org/D122082#3433503>, @beanz wrote:

> There are some gaps in the type analysis (constant expressions being one), but the method used here should apply. By mapping Values to typed pointer types, I can emit the typed pointer type in place of the opaque pointer type in the bitstream.

The bit I'm specifically concerned about is that you can't insert bitcasts in the prepare pass, as those would always get folded away. But I guess you can still materialize them directly during bitcode writing.

In D122082#3433503 <https://reviews.llvm.org/D122082#3433503>, @beanz wrote:

>> 2. How is dxil-dis supposed to work with opaque pointers?
>
> dxil-dis is LLVM 3.7's llvm-dis. It _can't_ handle opaque pointers, and doesn't need to. The references to the opaque pointer type are replaced with typed pointer types that are encoded matching LLVM 3.7's PointerType.

Oh, sorry, that was confusion on my part. Somehow I thought that dxil-dis is just a rebranded llvm-dis, I didn't realize that it's built from an external repo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122082/new/

https://reviews.llvm.org/D122082