[PATCH] D122082: Add DXIL Bitcode Writer and DXIL testing
Chris Bieneman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 6 10:11:47 PDT 2022
beanz added a comment.
In D122082#3433583 <https://reviews.llvm.org/D122082#3433583>, @nikic wrote:
> The bit I'm specifically concerned about is that you can't insert bitcasts in the prepare pass, as those would always get folded away. But I guess you can still materialize them directly during bitcode writing.
We only need to insert those because of how instructions are numbered in the bitcode writer. I don't _think_ we will need them in the ConstantExprs, but I may not be fully thinking that through. If we needed to materialize them in the bitwriter we can do that (especially now that we're forking the whole thing).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122082/new/
https://reviews.llvm.org/D122082
More information about the llvm-commits
mailing list