[PATCH] D122082: Add DXIL Bitcode Writer and DXIL testing

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

In D122082#3433065 <https://reviews.llvm.org/D122082#3433065>, @nikic wrote:

> In D122082#3429630 <https://reviews.llvm.org/D122082#3429630>, @beanz wrote:
>
>> @nikic, are you satisfied with the additional patches in the stack which support opaque pointers?
>
> I've only reviewed the first patch in the stack (D122268 <https://reviews.llvm.org/D122268>) yet, but have two high level questions:
>
> 1. How does/will this handle constant expressions?

There are some gaps in the type analysis (constant expressions being one), but the method used here should apply. By mapping Values to typed pointer types, I can emit the typed pointer type in place of the opaque pointer type in the bitstream.

> 2. How is dxil-dis supposed to work with opaque pointers?

dxil-dis is LLVM 3.7's llvm-dis. It _can't_ handle opaque pointers, and doesn't need to. The references to the opaque pointer type are replaced with typed pointer types that are encoded matching LLVM 3.7's PointerType.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122082/new/

https://reviews.llvm.org/D122082