[PATCH] D123068: Add the /nologo flag to llvm-ml

Alan Zhao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 09:28:47 PDT 2022


ayzhao updated this revision to Diff 420548.
ayzhao added a comment.

Update test for nologo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123068/new/

https://reviews.llvm.org/D123068

Files:
  llvm/test/tools/llvm-ml/basic.test
  llvm/tools/llvm-ml/Opts.td


Index: llvm/tools/llvm-ml/Opts.td
===================================================================
--- llvm/tools/llvm-ml/Opts.td
+++ llvm/tools/llvm-ml/Opts.td
@@ -65,6 +65,9 @@
 def define : MLJoinedOrSeparate<"D">, MetaVarName<"<macro>=<value>">,
              HelpText<"Define <macro> to <value> (or blank if <value> "
                       "omitted)">;
+def no_logo : MLFlag<"nologo">,
+              HelpText<"No effect as this tool never writes copyright data. "
+                       "Included for parity">;
 def output_file : MLJoinedOrSeparate<"Fo">, HelpText<"Names the output file">;
 def include_path : MLJoinedOrSeparate<"I">,
                    HelpText<"Sets path for include files">;
@@ -101,7 +104,6 @@
 def c_conventions : UnsupportedFlag<"Gd">, HelpText<"">;
 def stdcall_conventions : UnsupportedFlag<"GZ">, HelpText<"">;
 def extern_name_limit : UnsupportedSeparate<"H">, HelpText<"">;
-def nologo : UnsupportedFlag<"nologo">, HelpText<"">;
 def omf_object_file : UnsupportedFlag<"omf">, HelpText<"">;
 def full_listing : UnsupportedFlag<"Sa">, HelpText<"">;
 def first_pass_listing : UnsupportedFlag<"Sf">, HelpText<"">;
Index: llvm/test/tools/llvm-ml/basic.test
===================================================================
--- llvm/test/tools/llvm-ml/basic.test
+++ llvm/test/tools/llvm-ml/basic.test
@@ -1,3 +1,4 @@
-# RUN: not llvm-ml %t.blah.asm /Fo /dev/null 2>&1 | FileCheck -DMSG=%errc_ENOENT --check-prefix=ENOENT %s
+# RUN: not llvm-ml %t.blah.asm /nologo /Fo /dev/null 2>&1 | FileCheck -DMSG=%errc_ENOENT --check-prefix=ENOENT %s
 
+# ENOENT-NOT: nologo
 # ENOENT: {{.*}}.blah.asm: [[MSG]]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123068.420548.patch
Type: text/x-patch
Size: 1637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220405/06657ef0/attachment.bin>


More information about the llvm-commits mailing list