[PATCH] D123068: Add the /nologo flag to llvm-ml

[Alan Zhao via Phabricator via llvm-commits]

ayzhao marked an inline comment as done.
ayzhao added inline comments.


================
Comment at: llvm/tools/llvm-ml/Opts.td:70
+              HelpText<"No effect as this tool never writes copyright data. "
+                       "Included for parity">;
 def output_file : MLJoinedOrSeparate<"Fo">, HelpText<"Names the output file">;
----------------
hans wrote:
> For clang-cl we don't include ignored options in the /help output at all. See the cl_ignored_group in clang/include/clang/Driver/Options.td and how "nologo" is handled there. Maybe llvm-ml should handle ignored options similarly?
I don't think there's a consistent approach here - both llvm-cvtres and llvm-mt have help text for this flag (and in fact, I copied this help text from llvm-mt).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123068/new/

https://reviews.llvm.org/D123068