[PATCH] D123068: Add the /nologo flag to llvm-ml

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: llvm/test/tools/llvm-ml/basic.test:3
 
+# ENOENT-NOT: warning: ignoring unsupported 'nologo' option
 # ENOENT: {{.*}}.blah.asm: [[MSG]]
----------------
This test would still pass if llvm-ml printed something like "error: invalid option: '/nologo'". It's probably safest to check that "nologo" isn't mentioned in the output at all.


================
Comment at: llvm/tools/llvm-ml/Opts.td:70
+              HelpText<"No effect as this tool never writes copyright data. "
+                       "Included for parity">;
 def output_file : MLJoinedOrSeparate<"Fo">, HelpText<"Names the output file">;
----------------
For clang-cl we don't include ignored options in the /help output at all. See the cl_ignored_group in clang/include/clang/Driver/Options.td and how "nologo" is handled there. Maybe llvm-ml should handle ignored options similarly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123068/new/

https://reviews.llvm.org/D123068