[PATCH] D122580: RegAllocGreedy: Roll back successful recolorings on failure

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:101-104
+attributes #0 = { nounwind readonly }
+attributes #1 = { nounwind readnone }
+attributes #2 = { nounwind }
+attributes #3 = { nounwind writeonly }
----------------
arsenm wrote:
> jrtc27 wrote:
> > These shouldn't be needed
> These are part of the intrinsic declarations and aren't adding additional information. I prefer to keep attributes that are hardcoded on the intrinsic explicitly
We don't in RISC-V tests, they're not necessary and just add clutter


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122580/new/

https://reviews.llvm.org/D122580