[PATCH] D122580: RegAllocGreedy: Roll back successful recolorings on failure

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:89
+  call void @llvm.riscv.vse.nxv16f32.i64(<vscale x 16 x float> %i6, <vscale x 16 x float>* nonnull undef, i64 36)
+  unreachable
+}
----------------
arsenm wrote:
> jrtc27 wrote:
> > Is this really what you want rather than ret void?
> It doesn't really matter, this was just the reported reduced testcase
Sure, bugpoint is a bit overly aggressive. You'll probably also have certain people shouting at you for using undef rather than poison everywhere above...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122580/new/

https://reviews.llvm.org/D122580