[PATCH] D122580: RegAllocGreedy: Roll back successful recolorings on failure

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:89
+  call void @llvm.riscv.vse.nxv16f32.i64(<vscale x 16 x float> %i6, <vscale x 16 x float>* nonnull undef, i64 36)
+  unreachable
+}
----------------
jrtc27 wrote:
> Is this really what you want rather than ret void?
It doesn't really matter, this was just the reported reduced testcase


================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:101-104
+attributes #0 = { nounwind readonly }
+attributes #1 = { nounwind readnone }
+attributes #2 = { nounwind }
+attributes #3 = { nounwind writeonly }
----------------
jrtc27 wrote:
> These shouldn't be needed
These are part of the intrinsic declarations and aren't adding additional information. I prefer to keep attributes that are hardcoded on the intrinsic explicitly


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122580/new/

https://reviews.llvm.org/D122580