[PATCH] D122580: RegAllocGreedy: Roll back successful recolorings on failure

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:89
+  call void @llvm.riscv.vse.nxv16f32.i64(<vscale x 16 x float> %i6, <vscale x 16 x float>* nonnull undef, i64 36)
+  unreachable
+}
----------------
Is this really what you want rather than ret void?


================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:94
+declare <vscale x 16 x float> @llvm.riscv.vfwadd.mask.nxv16f32.nxv16f16.nxv16f16.i64(<vscale x 16 x float>, <vscale x 16 x half>, <vscale x 16 x half>, <vscale x 16 x i1>, i64, i64 immarg) #1
+declare dso_local void @_Z5checkIjEbPKT_S2_m() local_unnamed_addr
+declare <vscale x 16 x i16> @llvm.riscv.vrgather.vv.mask.nxv16i16.i64(<vscale x 16 x i16>, <vscale x 16 x i16>, <vscale x 16 x i16>, <vscale x 16 x i1>, i64, i64 immarg) #1
----------------
Give this a more reasonable name, separate it from the intrinsics and drop the unnecessary attributes (dso_local and local_unnamed_addr do nothing useful for declarations on RISC-V)


================
Comment at: llvm/test/CodeGen/RISCV/regalloc-last-chance-recoloring-failure.ll:101-104
+attributes #0 = { nounwind readonly }
+attributes #1 = { nounwind readnone }
+attributes #2 = { nounwind }
+attributes #3 = { nounwind writeonly }
----------------
These shouldn't be needed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122580/new/

https://reviews.llvm.org/D122580